Hey,
I think monero is interesting and want to support it a little.
To do so i setup a public full node on my home-server (3900x with NVMe SSD) and configured it so that it is allowed to use up to 50% of my bandwidth (i have 500 MBit/s down and 40 MBit/s up)
I'm now not that sure how to configure in-peers and out-peers in a way that strengthens the network.
My assumption would be that a high number of out-peers is bad because my server would be blocking in-connections of other nodes, and a high number if in-peers is good because i allow more people to download the chain.
Are these assumptions correct?
What would be some good values for in-peers and out-peers?
I currently configured 128 out-peers and 1024 in-peers. Is one of these exessive or not enough?
Update:
I decided to go with 64 out-peers and 256 in-peers for now. See this comment for an explanation
If the comments tell you "what" happens, then yes, they can geht outdated fast. The details of how something works can change quickly.
But comments documenting "why" something is done (a certain way) - explaining the intent - are probably valid for mich longer.
In the best case comments aren't viewed as something that is seperate from the code, but part of it. So that if someone changes the code, the comments has to be checked aswell (if the explanation of "why" something is done actually changed).