this post was submitted on 05 Mar 2024
135 points (88.1% liked)
Open Source
31253 readers
271 users here now
All about open source! Feel free to ask questions, and share news, and interesting stuff!
Useful Links
- Open Source Initiative
- Free Software Foundation
- Electronic Frontier Foundation
- Software Freedom Conservancy
- It's FOSS
- Android FOSS Apps Megathread
Rules
- Posts must be relevant to the open source ideology
- No NSFW content
- No hate speech, bigotry, etc
Related Communities
Community icon from opensource.org, but we are not affiliated with them.
founded 5 years ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
You review the ideas & code at a high level. I feel like you didn’t read the “nit” part. Instead I get review for my flyby patch (no plans to be a mainstay) where the idea is fine, but the maintainer wants me to worry about variable names, spacing, & other BS that doesn’t matter. You get a ton of “please add space here” type comments & the maintainer is putting the onus on you to fix their quirks which leads to a really slow review process full of irrelevant nitpicks. A maintainer should just merge that code & fix the nits themselves rather than expecting everyone to care about their naming conventions. Pull request model in an MS GitHub-like UI encourages this behavior.