this post was submitted on 07 Jun 2023
0 points (NaN% liked)
Lemmy
12518 readers
75 users here now
Everything about Lemmy; bugs, gripes, praises, and advocacy.
For discussion about the lemmy.ml instance, go to [email protected].
founded 4 years ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
You thinking just a with the 4 links in it and a header of some sort? Mock or description or anything?
I think at the top, just above the "Recommended" add:
Not sure who the approved reviewers are.
https://github.com/LemmyNet/joinlemmy-translations/pull/12 <-- translations PR, prerequisite of other PR
https://github.com/LemmyNet/joinlemmy-site/pull/158 <-- DRAFT PR. This one will need the translations folder updated after the translations PR is done. There might be a better way to do this, but I almost never work on submodules in this way.
That's @[email protected]
Translation merged. Actual HTML in full PR. Once/if @[email protected] approves, we'll be.... Nevermind, he just approved it. He said it'll be live in an hour or two.
There wasn't really anything that resembled typescript changes ultimately. The submoduled translations were the only real time sink there.