Programming

17436 readers

275 users here now

Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!

Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.

Hope you enjoy the instance!

Rules

Follow the programming.dev instance rules
Keep content related to programming in some way
If you're posting long videos try to add in some form of tldr for those who don't want to watch videos

Wormhole

Follow the wormhole through a path of communities [email protected]

founded 1 year ago

MODERATORS

[email protected]

Why does a control path not execute in this function? (lemm.ee)

submitted 1 year ago by [email protected] to c/[email protected]

12 comments fedilink hide all child comments

In VS I am told this function "does not return a value in all control paths." A bot told me specifically the issue is with this line: else if (letter + key <= 90). It said that if the outcome results in letter + key equally exactly 90 then a value is not returned, but I thought that was covered where '<=' means 'less than or equals.'

char rotate(char letter, int key)
{
    if (isalpha(letter) == true)
    {
        if (letter + key > 90)
        {
            int overage = letter + key - 90;
            letter = 64 + overage;

            while (letter > 90)
            {
                overage = letter - 90;
                letter += overage;
            }

            return letter;
        }

        else if (letter + key &lt;= 90)
        {
            letter += key;
            return letter;
        }
    }

    else if (isalpha(letter) == false)
    {
        return letter;
    }

you are viewing a single comment's thread
view the rest of the comments

[–] [email protected] 5 points 1 year ago

you are checking the result of a method that returns a boolean (true/false) there is no reason to check for true, else, FILE_NOT_FOUND. you can also forgo equating its return value to something to get a boolean value required for the if statement since its already a boolean value.

e.g.

if (isalpha(letter)) 
{ 
   // ...
} 
else 
{ 
   // ...
}