this post was submitted on 11 Nov 2023
75 points (80.0% liked)
Programming
17405 readers
186 users here now
Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!
Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.
Hope you enjoy the instance!
Rules
Rules
- Follow the programming.dev instance rules
- Keep content related to programming in some way
- If you're posting long videos try to add in some form of tldr for those who don't want to watch videos
Wormhole
Follow the wormhole through a path of communities [email protected]
founded 1 year ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
That's nice and all, but if you submit your array reversing code to me for peer review, I'm going to ask our boss for a private meeting, where I will ask him to fire you. And if you were just hired a week ago... you'd still be on probation and very easy to fire, we'll just call up one of the other job applicants for your position and see if they're interested.
Don't waste my time by asking me to review unnecessarily complex code. Also we have enough bugs already and you seem to be going out of your way to introduce even more.
For the record - the right way to reverse an array in PHP is like this:
array_reverse($array). And if that's too slow... just don't reverse it at all. Use--instead of++in your for loop.(PS: Ugh. Lemmy sucks for posting code... didn't like some of the symbols and ate my whole comment. Had to write it twice. Sorry the first one was better)
That's not the point of the article though. Reversing an array is simply an exemple of a very simple CS puzzle. Of course it's common enough to have a builtin function. No, this won't be written in a code base, or asked for a code review. That's not the point.
My point is I don't like complex solutions to simple problems.
It's an algorithm question. If somebody gave me your solution in an interview I would ask them to solve the problem without a dependency. These questions are about demonstrating your ability to code whilst understanding space & time complexity.